Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle interface names containing "." #109

Closed
wants to merge 1 commit into from

Conversation

larsks
Copy link
Member

@larsks larsks commented Jan 29, 2014

This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1057938 for
astapor by calling regsubst() to replace "." with "" in interface names
when looking up ipaddress
* facts.

This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1057938 for
astapor by calling regsubst() to replace "." with "_" in interface names
when looking up ipaddress_* facts.
@cwolferh
Copy link

Nice!

@jguiditta
Copy link
Member

Lars, thanks for the contribution, this has popped up in a couple variations recently. Apparently this is no longer able to be automatically merged. I can either fix it in my own checkout of your branch and merge it that way, or you can update, either way. Also, minor request, which I can do if you are busy (I really need to update the readme or add a contributing file). For BZs, it makes it easier on me to make sure I catch the relevant info in the spec changelog if people use the following format:

BZ #<number>, #<number> - short summary

<bz link(s)>

any additional text

I specifically call out plural in this case because I think your fix corrects 2 BZs, which has not happened to me before. The second is for rhos, here, if you care to include:

https://bugzilla.redhat.com/show_bug.cgi?id=1056892

@larsks
Copy link
Member Author

larsks commented Jan 31, 2014

I'll update the patch...should have it ready in a jiffy.

@larsks
Copy link
Member Author

larsks commented Jan 31, 2014

Updated patch is #111.

@larsks larsks closed this Jan 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants