Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bz 1059417,1056892 -- Handle interface names containing "." or "-" #112

Merged
merged 1 commit into from Feb 3, 2014

Conversation

larsks
Copy link
Member

@larsks larsks commented Feb 3, 2014

Thanks to Rob's comment in #111:

This updates the previous patch to also handle interface names
containing "-".

This updates the previous patch to also handle interface names
containing "-".
@robparrott
Copy link

Ha ha (picture bully kid from Simpsons) 

On February 3, 2014 at 10:31:14 AM, Lars Kellogg-Stedman (notifications@github.com) wrote:

Thanks to Rob's comment in #111:

This updates the previous patch to also handle interface names
containing "-".

You can merge this Pull Request by running:

git pull https://github.com/larsks/astapor bz/1059417

Or you can view, comment on it, or merge it online at:

#112

-- Commit Summary --

  • bz 1059417,1056892 -- Handle interface names containing "."
    or "-"

-- File Changes --

M puppet/modules/quickstack/manifests/neutron/compute.pp
(2)
M puppet/modules/quickstack/manifests/neutron/networker.pp
(4)
M puppet/modules/quickstack/manifests/storage_backend/lvm_cinder.pp
(2)
M puppet/modules/quickstack/manifests/swift/storage.pp
(2)

-- Patch Links --

https://github.com/redhat-openstack/astapor/pull/112.patch
https://github.com/redhat-openstack/astapor/pull/112.diff


Reply to this email directly or view it on GitHub:
#112

@jguiditta
Copy link
Member

Thanks guys, that does look more robust. Wonder if we should later consider a function to check this to avoid duplication..

jguiditta added a commit that referenced this pull request Feb 3, 2014
bz 1059417,1056892 -- Handle interface names containing "." or "-"
@jguiditta jguiditta merged commit 735e00d into redhat-openstack:master Feb 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants