Systemd needs to access container_file_t for side-cars #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neutron "side-cars" containers are now managed by Systemd instead of in-container wrappers. Basically, Systemd is instructed to check a certain location and take action upon file creation|change|deletion. Since this "flag" is managed from within neutron container(s), Systemd must be allowed to go in there. Related: https://bugs.launchpad.net/tripleo/+bug/1853652
cjeanner
force-pushed
the
podman_init_t
branch
from
08df696
to
a0521ff
Compare
jpichon
requested changes
Dec 17, 2019
There was a problem hiding this comment.
One small additional changes is required as the test file is currently a no-op:
https://github.com/redhat-openstack/openstack-selinux/blob/master/Makefile#L73-L74
Test files are installed in two steps at the moment to preserve the correct mode. Unfortunately only test files starting with bz are copied over so we'll want to add something for lp.
Looks like that could be fixed with 2 changes:
${INSTALL} -m 0644 tests/bz* tests/lp* ${LOCALDIR}/testson the Makefile- Changing TEST_FILES to also list lp* in tests/check_all (
TEST_FILES=$(/bin/ls -1 bz* lp*))
Hope that makes sense. Thank you!
|
Change added as a new commit in order to be keep the "one change one commit" idea. |
jpichon
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neutron "side-cars" containers are now managed by Systemd instead of
in-container wrappers.
Basically, Systemd is instructed to check a certain location and take
action upon file creation|change|deletion. Since this "flag" is managed
from within neutron container(s), Systemd must be allowed to go in
there.
Related: https://bugs.launchpad.net/tripleo/+bug/1853652