Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow to add new dependencies #1224

Merged
merged 2 commits into from Jun 12, 2018
Merged

Update workflow to add new dependencies #1224

merged 2 commits into from Jun 12, 2018

Conversation

amoralej
Copy link
Contributor

According to new automation based on rdoinfo.

According to new automation based on rdoinfo.
Copy link
Contributor

@hguemar hguemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CBS but not pushed to any RDO repository.
- `el7-build` (only available for Rocky and newer releases)
is assigned to packages that only required to build other
packages but not to deploy or run any OpenStack service.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but are not a runtime requirement for any other package (it looks a bit confusing).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


If the package is found for the required CBS tag, it's already in RDO repositories
and no more actions are needed to add it to the repos.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to add a simple flow to explain the flow:

-candidate -> -testing -> -release
-candidate -> -el7-build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the flow in second patch.

create a gerrit review as explained in step 5.

<br />
7. Once the package is rebuilt in CBS (review in step 5 is merged) you can pushed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can push it (typo in pushed)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

According to feedback in the PR.
@hguemar hguemar merged commit de6df4b into redhat-openstack:master Jun 12, 2018
@hguemar
Copy link
Contributor

hguemar commented Jun 12, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants