New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc to retire package #1278
Conversation
- Send a review to [rdoinfo project in review.rdoproject.org](https://review.rdoproject.org/r/#/q/project:rdoinfo). | ||
In this change you need to delete the tag for the project for which package is not needed to built. | ||
|
||
Once the change is merged in rdoinfo, package will no longer exist in RDO trunk repo:- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add "but it will still be built for previous releases"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me, just a couple small nits.
1. toc | ||
{:toc} | ||
|
||
### How to remove an OpenStack package from RDO Trunk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This procedure will retire it from RDO Trunk and also prevent it from being in the next CloudSIG repo. Please, explain it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
||
### How to remove an OpenStack package from RDO Trunk | ||
|
||
Package for a project can exist across different releases. So retiring it in RDO needs to go via stages, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should allow retire packages only from on-development release not after GA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a NOTE
Package for a project can exist across different releases. So retiring it in RDO needs to go via stages, | ||
To remove a package, following steps are required:- | ||
|
||
Stage 1:- Project Source is retired/deleted upstream, but it's package still need to be maintained because it's required by other projects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick, it'd be good to use bold format for "Stage X".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
||
Stage 1:- Project Source is retired/deleted upstream, but it's package still need to be maintained because it's required by other projects | ||
|
||
- Send a review to `rdoinfo` like [Example review](https://review.rdoproject.org/r/#/c/20387/) to pin(add source-branch: `<good commit>`) the project against the tag or commit, so package get's build from pinned commit rather than latest commit(deleted source code). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example is confusing because it's pinning multiple releases while the regular case should be that only master tags should be pinned (in oslo-sphinx they didn't create stable/rocky nor stable/stein). I guess we don't have a better one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes right didn't find a better one for retiring case.
|
||
Stage 2:- Package is no longer needed by other projects:- | ||
|
||
- Send a review to [rdoinfo project in review.rdoproject.org](https://review.rdoproject.org/r/#/q/project:rdoinfo). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we have an example for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it's not there yet
``` | ||
|
||
- Delete the project spec files and add dead.package file mentioning the reason of removal | ||
- Remove project completely(project-config, resource,gerritbot etc) from zuul config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't remove the resource, project-config, etc... as we still maintain it for stable releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm this step is only valid when package is no longer build and required for any releases. Low chance for such a case though.
Also updated following:- - remove references for stein-py3-uc tag which is no longer valid - Add mapping for RDO Trunk Repos and Tag in rdoinfo - Add info for master-head DLRN builder
No description provided.