Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release criteria for Ussuri #1374

Merged
merged 1 commit into from May 21, 2020
Merged

Add release criteria for Ussuri #1374

merged 1 commit into from May 21, 2020

Conversation

amoralej
Copy link
Contributor

This comes from old definition of done in [1].

[1] https://blogs.rdoproject.org/2016/05/technical-definition-of-done/

javierpena
javierpena approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@javierpena javierpena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me.

karelyatin
karelyatin reviewed May 13, 2020
View reviewed changes
Copy link
Contributor

@karelyatin karelyatin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rainleander
rainleander approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@rainleander rainleander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, these tests / scenarios are also listed somewhere on rdoproject.org and linked, but it may be approved as is, if you like.

apevec
apevec approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@apevec apevec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

If possible, could we update or comment on old blog https://blogs.rdoproject.org/2016/05/technical-definition-of-done/ linking to this section?

@amoralej amoralej merged commit 6903108 into redhat-openstack:master May 21, 2020
@amoralej
Copy link
Contributor Author

+1

If possible, could we update or comment on old blog https://blogs.rdoproject.org/2016/05/technical-definition-of-done/ linking to this section?

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karelyatin karelyatin karelyatin left review comments

@apevec apevec apevec approved these changes

@javierpena javierpena javierpena approved these changes

@rainleander rainleander rainleander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@amoralej @apevec @javierpena @rainleander @karelyatin