Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double pointer #36

Merged

Conversation

nocturnalastro
Copy link
Collaborator

No description provided.

@nocturnalastro nocturnalastro marked this pull request as ready for review June 22, 2023 14:21
@nocturnalastro nocturnalastro marked this pull request as draft June 22, 2023 14:22
@nocturnalastro nocturnalastro marked this pull request as ready for review June 22, 2023 15:24
Copy link
Contributor

@crwr45 crwr45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change, otherwise good!

@@ -36,7 +36,7 @@ type CollectorRunner struct {
collectorQuitChannel map[string]chan os.Signal
pollResults chan collectors.PollResult
erroredPolls chan collectors.PollResult
collecterInstances map[string]*collectors.Collector
collecterInstances map[string]collectors.Collector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, just spotted: "collectorInstances"

@nocturnalastro nocturnalastro merged commit ce9cefb into redhat-partner-solutions:main Jun 23, 2023
4 checks passed
@nocturnalastro nocturnalastro deleted the fixDoublePointer branch June 23, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants