Replace Rate per second with interval in seconds #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crwr45
approved these changes
Jun 28, 2023
| @@ -97,7 +97,7 @@ func NewGPSCollector(constructor *CollectionConstructor) (Collector, error) { | |||
| ctx: ctx, | |||
| running: false, | |||
| callback: constructor.Callback, | |||
| pollRate: constructor.PollRate, | |||
| pollInterval: constructor.PollInterval, | |||
There was a problem hiding this comment.
Can also remove mentions of ShouldPoll above as it no longer exists.
Rate per second seemd to be confusing so instead we denote the rate interms of a time interval between polls
nocturnalastro
force-pushed
the
replaceRateWithInterval
branch
from
7a9b2f8
to
a7b2f27
Compare
nocturnalastro
merged commit f2a83b6
into
redhat-partner-solutions:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rate per second seemd to be confusing so instead we denote the rate interms of a time interval between polls