Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Support for negation "^" in the cpulist_unpack function #49

Closed
krsacme opened this issue May 10, 2017 · 4 comments
Closed

[RFE] Support for negation "^" in the cpulist_unpack function #49

krsacme opened this issue May 10, 2017 · 4 comments

Comments

@krsacme
Copy link
Contributor

krsacme commented May 10, 2017

In OpenStack, some of the configuration support negation, like, having the cpu list as ["1-5", "^3"], should eventually add the list as "1,2,4,5". We have a scenario where we need to pass the same list of parameter to both OpenStack and tuned (tuned-profile-cpu-partitioning's isolated_cores).

The expansion can be added at the caller, and it has to be added in multiple places. If it is done in the tuned it would be nice to have feature and has consistency.

@krsacme
Copy link
Contributor Author

krsacme commented May 10, 2017

@yarda - would like to know your inputs?

@yarda
Copy link
Contributor

yarda commented May 12, 2017

Do you talk about isolated_cores settings in cpu-partitioning-variables.conf? If yes, I think we could add support for negation into cpulist_unpack or cpulist_present Tuned built-in functions. Maybe I would prefer '!' as negation, but it shouldn't be problem to support both syntaxes ('!' and '^'), e.g. the following:
isolated_cores=2,4-7,!8

@yarda
Copy link
Contributor

yarda commented May 12, 2017

Ah, it's clear from the subj. I am for it.

@krsacme
Copy link
Contributor Author

krsacme commented May 13, 2017

Thanks @yarda. I should be able to raise a pull request by next week.

krsacme pushed a commit to krsacme/tuned that referenced this issue May 15, 2017
cpulist_unpack supports range, it would be good add negation
support via ^ or !, inorder to exclude cpus from the specified
range.
Fixes redhat-performance#49
@yarda yarda closed this as completed in #51 May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants