New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of unittest2, use unittest from the standard library #249
Conversation
Fixes redhat-performance#241 Fedora is removing the unittest2 package: https://bugzilla.redhat.com/show_bug.cgi?id=1794222 tuned is not targeting Python 2.6: redhat-performance#241 (comment) One thing not present in Python 2.7 is assertItemsEqual() -- renamed to assertCountEqual(). Related, mock was also listed as a requirement in the spec file, but all the imports are from unittest.mock, hence removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/packit copr-build |
@yarda Please take a look at this. |
There was an error while creating SRPM. You can re-trigger build by adding a comment ( Output:
|
/packit copr-build |
I've tried to parse the packit error, and I think it is broken, but not by this PR. |
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Yes, it happens all the time. Nothing to worry about ;). |
Can we please get this merged so I can backport it to https://src.fedoraproject.org/rpms/tuned/pull-request/2 ? Or should I backport AS IS? |
Thanks, merging, sorry for delay. |
Thank You. |
Fixes #241
Fedora is removing the unittest2 package: https://bugzilla.redhat.com/show_bug.cgi?id=1794222
tuned is not targeting Python 2.6: #241 (comment)
One thing not present in Python 2.7 is
assertItemsEqual()
-- renamed toassertCountEqual()
.Related,
mock
was also listed as a requirement in the spec file,but all the imports are from
unittest.mock
, hence removed.