plugin_net: Fix check for channels supported mode #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 0ab1f8c adds a check which replaces the channels mode parameters based on the supported mode. With the older kernels, the un-supported mode was indicated by 0, however recently that has been replaced by a string 'n/a'. Due to this the check in plugin_net that verifies if a replacement is required or not fails. Fix the check to incorporate this new string that indicates the un-supported mode. Resolves: rhbz#1943291 Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
|
@yarda Hi, any comments here? |
|
@niteshnarayanlal LGTM, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 0ab1f8c adds a check which replaces the channels mode parameters
based on the supported mode. With the older kernels, the un-supported mode
was indicated by 0, however recently that has been replaced by a string 'n/a'.
Due to this the check, in plugin_net that verifies if a replacement is
required or not fails.
Fix the check to incorporate this new string that indicates the un-supported
queue mode.
Resolves: rhbz#1943291
Signed-off-by: Nitesh Narayan Lal nitesh@redhat.com