cpu_partitioning: fixed no_balance_cores on newer kernels #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarda
force-pushed
the
no-balance-cores-fix
branch
from
a94875c
to
7858b25
Compare
yarda
changed the title
jmencak
reviewed
Dec 16, 2021
jmencak
reviewed
Dec 16, 2021
profiles/cpu-partitioning/tuned.conf
Outdated
| @@ -35,6 +35,8 @@ no_balance_cores_expanded=${f:cpulist_unpack:${no_balance_cores}} | |||
| # Fail if isolated_cores contains CPUs which are not online | |||
| assert2=${f:assertion:isolated_cores contains online CPU(s):${isolated_cores_expanded}:${isolated_cores_online_expanded}} | |||
|
|
|||
| cmd_isolcpus=${f:regex_search_ternary:${no_balance_cores}:\s*[0-9]+: isolcpus=${no_balance_cores}:} | |||
There was a problem hiding this comment.
We can drop the + in the regex.
Thanks for the review. According to the discussion in the Red Hat bugzilla this should work OK on RHEL-8, but in the RHEL-8 downstream this PR will be reverted not to cause any regression or different behaviour. On newer RHELs this upstream version of the profile will be used. |
I.e. kernels without the SD_LOAD_BALANCE. Resolves: rhbz#1874596 Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
yarda
force-pushed
the
no-balance-cores-fix
branch
from
7858b25
to
83ee596
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…LOAD_BALANCE
Resolves: rhbz#1874596
Signed-off-by: Jaroslav Škarvada jskarvad@redhat.com