Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pm_qos_resume_latency_us option for cpu plugin. #485

Conversation

CZerta
Copy link
Contributor

@CZerta CZerta commented Dec 5, 2022

Resolves: rhbz#2118786

Signed-off-by: Jan Zerdik jzerdik@redhat.com

@CZerta CZerta requested review from yarda and joemario December 5, 2022 12:22
@CZerta
Copy link
Contributor Author

CZerta commented Dec 5, 2022

@joemario Should we disable dynamic tuning similarly as it is dissabled with force_latency option?

@yarda
Copy link
Contributor

yarda commented Dec 6, 2022

@joemario Should we disable dynamic tuning similarly as it is dissabled with force_latency option?

Dynamic tuning is disabled in RHEL. If enabled, it dynamically changes the global PM QoS according to the CPU load. I think it should work per CPU plugin instance. I.e. instead of the global PM QoS each plugin instance should dynamically change the PM QoS just for the CPUs in the instance. If the PM QoS is set explicitly for the instance, the instance shouldn't perform the dynamic tuning.

@joemario
Copy link

joemario commented Dec 6, 2022

Thank you Jaroslav for the info on dynamic tuning. I was unaware of those details.

Resolves: rhbz#2118786

Signed-off-by: Jan Zerdik <jzerdik@redhat.com>
@CZerta CZerta force-pushed the rhbz2118786_pm_qos_resume_latency_us_option branch from 73736ca to 3490df4 Compare January 16, 2023 15:34
@yarda yarda self-requested a review February 8, 2023 11:23
Copy link
Contributor

@yarda yarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the conflict.

@yarda yarda self-requested a review February 8, 2023 11:53
@yarda yarda merged commit 225a70c into redhat-performance:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants