Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No errors when physical_package_id file does not exist #542

Merged

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Jun 28, 2023

Show no errors when the physical_package_id file does not exist -- the CPUs may be offline.

Resolves: rhbz#2217015

@jmencak jmencak requested a review from yarda August 9, 2023 09:27
@jmencak
Copy link
Contributor Author

jmencak commented Aug 9, 2023

@yarda would that be the right approach for fixing rhbz#2217015 ?

@yarda
Copy link
Contributor

yarda commented Aug 16, 2023

/packit build

@yarda
Copy link
Contributor

yarda commented Aug 16, 2023

Maybe you could write debug message that the physical_package_id doesn't exist and was skipped.

Show no errors when the physical_package_id file does not exist -- the
CPUs may be offline.

Resolves: rhbz#2217015

Signed-off-by: Jiri Mencak <jmencak@users.noreply.github.com>
@jmencak jmencak force-pushed the rhbz2217015-no-errors-on-offline-cpus branch from 9470f73 to a0902c2 Compare August 16, 2023 20:40
@jmencak
Copy link
Contributor Author

jmencak commented Aug 16, 2023

Maybe you could write debug message that the physical_package_id doesn't exist and was skipped.

Thank you for the review. Done.

@yarda yarda merged commit 0337596 into redhat-performance:master Aug 16, 2023
16 checks passed
@jmencak jmencak deleted the rhbz2217015-no-errors-on-offline-cpus branch August 17, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants