Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RHEL-36636) ci: Allow to pass parameters together with rhel-only note #9

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Jun 21, 2024

Supported parameters:

  • feature - for feature related commits (cross-version)
  • bugfix - for bugfix related commits (cross-version)
  • doc - for documentation related commits (usually version specific)
  • workaround - for workaround related commits (usually version-specific)
  • ci - for CI related commits (version specific)
  • test - for test related commits (version specific)
  • other - for commits that do not fit into any of the above categories or use just rhel-only

rhel-only: ci

Related: RHEL-36636

@jamacku jamacku added this to the RHEL-10.0.BETA milestone Jun 21, 2024
@github-actions github-actions bot changed the title ci: Allow to mark RHEL10 only downstream commits (RHEL-36636) ci: Allow to mark RHEL10 only downstream commits Jun 21, 2024
Copy link

github-actions bot commented Jun 21, 2024

Commit validation

Tracker - RHEL-36636

The following commits need an inspection

commit note
16b10ca - ci: allow to pass parameters together with rhel-only note Missing upstream reference ‼️

Tracker validation

Success

🟢 Tracker RHEL-36636 has set desired product: CentOS Stream 10
🟢 Tracker RHEL-36636 has set desired component: systemd
🟢 Tracker RHEL-36636 has been approved


Pull Request validation

Success

🟡 CI - Waived
🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved


Auto Merge

Success

🟢 Pull Request is not marked as draft and it's not blocked by dont-merge label
🟢 Pull Request meet requirements, title has correct form
🟢 Pull Request meet requirements, mergeable is true
🟠 Pull Request meet requirements, mergeable_state is unstable
🟢 Pull Request has correct target branch main
🟢 Pull Request was merged

@jamacku jamacku marked this pull request as draft June 23, 2024 06:37
@dtardon
Copy link
Member

dtardon commented Jun 24, 2024

Hmm, I was proposing something different: to make this parametrized. I.e., write RHEL-only: foo, where foo could be one of feature, ci, other (subject to bikeshedding). That is, each change would be tagged with its purpose, which would then serve as a hint what to do with the change on a rebase (features - copy over, ci changes - ignore). That seems better to me than to add a new keyword for every major RHEL release...

@jamacku
Copy link
Member Author

jamacku commented Jun 24, 2024

Thanks @dtardon, now I see.

@jamacku jamacku changed the title (RHEL-36636) ci: Allow to mark RHEL10 only downstream commits (RHEL-36636) ci: Allow to pass parameters together with rhel-only note Jun 25, 2024
@jamacku
Copy link
Member Author

jamacku commented Jun 25, 2024

@dtardon, I have added an option to allow passing parameters together with rhel-only notes, as you suggested. Could you please have another look? Thank you.

Supported parameters:

* feature - for feature related commits (cross-version)
* bugfix - for bugfix related commits (cross-version)
* doc - for documentation related commits (usually version specific)
* workaround - for workaround related commits (usually version specific)
* ci - for CI related commits (version specific)
* test - for test related commits (version specific)
* other - for commits that do not fit into any of the above categories or use just `rhel-only`

rhel-only: ci

Related: RHEL-36636
Copy link
Member

@dtardon dtardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamacku jamacku marked this pull request as ready for review June 25, 2024 12:41
@github-actions github-actions bot merged commit 7f78b51 into redhat-plumbers:main Jun 25, 2024
15 of 19 checks passed
@jamacku jamacku deleted the rhel10only branch June 25, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants