mount-setup: change the system mount propagation to shared by default only at bootup #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… only at bootup The commit b3ac5f8 has changed the system mount propagation to shared by default, and according to the following patch: opencontainers/runc#208 When starting the container, the pouch daemon will call runc to execute make-private. However, if the systemctl daemon-reexec is executed after the container has been started, the system mount propagation will be changed to share again by default, and the make-private operation above will have no chance to execute. (cherry picked from commit f74349d) Signed-off-by: Yuanhong Peng <yummypeng@linux.alibaba.com>
systemd-rhel-bot
added
pr/needs-ci
|
We don't plan to merge this PR. It needs a proper tracker (JIRA issue). Also, RHEL7 in Maintenance Support 2 Phase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit b3ac5f8 has changed the system mount propagation to
shared by default, and according to the following patch:
opencontainers/runc#208
When starting the container, the pouch daemon will call runc to execute
make-private.
However, if the systemctl daemon-reexec is executed after the container
has been started, the system mount propagation will be changed to share
again by default, and the make-private operation above will have no chance
to execute.
(cherry picked from commit f74349d)
Signed-off-by: Yuanhong Peng yummypeng@linux.alibaba.com