(#1968528) sd-event ratelimiting followups #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of ordering non-pending before pending we should order "non-pending OR ratelimited" before "pending AND not-ratelimited". This fixes a bug where ratelimited events were ordered at the end of the priority queue and could be stuck there for an indeterminate amount of time. (cherry picked from commit 81107b8) Related: #1968528
(cherry picked from commit 7e2bf71) Related: #1968528
(cherry picked from commit 06e1314) Related: #1968528
(cherry picked from commit a595fb5) Related: #1968528
…ource type But it does nothing for an event source which is neither a timer nor ratelimited. (cherry picked from commit 5c08c7a) Related: #1968528
Before 81107b8, the compare functions for the latest or earliest prioq did not handle ratelimited flag. So, it was ok to not reshuffle the time prioq when changing the flag. But now, those two compare functions also compare the source is ratelimited or not. So, it is necessary to reshuffle the time prioq after changing the ratelimited flag. Hopefully fixes #19903. (cherry picked from commit 2115b9b) Related: #1968528
systemd-rhel-bot
added
pr/needs-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.