(#2070097) udev/net_id: avoid slot based names only for single function devices #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have two or more devices that share the same slot but they are also multifunction then it is OK to use the slot information even if it is the same for all of them. Name conflict will be avoided because we will append function number and form names like, ens1f1, ens1f2... (cherry picked from commit 66425da) Resolves: #2070097
systemd-rhel-bot
added
pr/needs-ci
jamacku
reviewed
Apr 7, 2022
There was a problem hiding this comment.
Looks like the CentOS CI fail is unrelated and will be fixed in 9.1 by #72.
\cc @mrc0mmand
systemd-rhel-bot
removed
pr/needs-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have two or more devices that share the same slot but they are
also multifunction then it is OK to use the slot information even if it
is the same for all of them. Name conflict will be avoided because we
will append function number and form names like, ens1f1, ens1f2...
(cherry picked from commit 66425da)
Resolves: #2070097