Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not get rolling update to work #1

Closed
sebastienblanc opened this issue Oct 19, 2020 · 3 comments
Closed

Can not get rolling update to work #1

sebastienblanc opened this issue Oct 19, 2020 · 3 comments

Comments

@sebastienblanc
Copy link

This step https://redhat-scholars.github.io/openshift-starter-guides/rhs-openshift-starter-guides/nationalparks-java-pipeline-codechanges-github.html#rollback is not working for me, could it be because it always uses the latest image ?

I also do not get the warning that is shown in the instructions "Warning: the following images triggers were disabled: nationalparks:latest"

@blues-man

@blues-man
Copy link
Contributor

I need to test it again, that's not expected.

@blues-man
Copy link
Contributor

Right, using latest avoids rolling back, I missed this step, I need to fix this thanks for reporting.

@blues-man
Copy link
Contributor

It looks that using the YAML editing now it keeps the trigger on, that's why I was adding that part on the Tekton task about using latest (like for a Deployment)

I'm gonna push a fix replacing the YAML editing with this command to disable triggers:
oc set triggers dc nationalparks --manual

Then leaving only rollout in redeploy Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants