Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] <rh-cta> focus style #1528

Closed
2 tasks
marionnegp opened this issue Apr 18, 2024 · 1 comment · Fixed by #1538
Closed
2 tasks

[bug] <rh-cta> focus style #1528

marionnegp opened this issue Apr 18, 2024 · 1 comment · Fixed by #1538
Assignees
Labels
bug Something isn't working for dev Ready for development priority: high High priority

Comments

@marionnegp
Copy link
Collaborator

marionnegp commented Apr 18, 2024

Describe the bug

<rh-cta>'s focus state currently looks like:
Screenshot 2024-04-18 at 4 06 19 PM

Screenshot 2024-04-19 at 10 19 22 AM

The focus state then would look like the hover state + a focus ring.

  • This will also have to be updated in the docs. The current mockups in the docs don't have enough contrast between the focus ring and adjacent colors.

Which Component?

rh-cta

Steps to reproduce

  1. Go to the CTA demo.
  2. Tab through the different variants to see focus states.

Expected behaviour

Should look like the focus states mocked up in the CTA docs.

Screenshots

No response

Element HTML

No response

Operating System (OS)

macOS

Browser

No response

More browser information

No response

Additional Info

No response

@marionnegp marionnegp added the bug Something isn't working label Apr 18, 2024
@markcaron markcaron changed the title [bug] <rh-cta> focus style [bug] <rh-cta> focus style Apr 29, 2024
@markcaron markcaron added priority: high High priority for dev Ready for development labels Apr 29, 2024
@adamjohnson adamjohnson linked a pull request Apr 30, 2024 that will close this issue
3 tasks
@marionnegp
Copy link
Collaborator Author

Closed by #1538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working for dev Ready for development priority: high High priority
Projects
Status: Done ☑️
Development

Successfully merging a pull request may close this issue.

3 participants