Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of wrapper script opm-auths #116

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tonyskapunk
Copy link
Contributor

@tonyskapunk tonyskapunk commented Jan 4, 2024

The opm-auths is a wrapper script provided by dci-openshift-agent that brings support for multi-entry registry authentication when using opm.

The opm client lacked the functionality as reported in: operator-framework/operator-registry#935

But lately it was added in:
operator-framework/operator-registry#1165

Now it is not yet available in the stable ocp clients:
https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/stable/

Depends-On: https://softwarefactory-project.io/r/c/dci-openshift-agent/+/30506

The opm-auths is a wrapper script provided by dci-openshift-agent
that brings support for multi-entry registry authentication when
using opm.

The opm client lacked the functionality as reported in:
operator-framework/operator-registry#935

But lately it was added in:
operator-framework/operator-registry#1165

Now it is available in the stable ocp clients:
https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/stable/
@tonyskapunk tonyskapunk requested a review from a team as a code owner January 4, 2024 20:16
Copy link

Copy link
Contributor

@pierreblanc pierreblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Tony ! Thx.
LVGTM

@tonyskapunk tonyskapunk marked this pull request as draft January 4, 2024 22:05
@tonyskapunk
Copy link
Contributor Author

My initial test was incorrect and the stable version of opm (through OCP) does not matches yet the latest upstream version where the support to multiple-entry registries is implemented yet. Moved to draft for the time being.

@tonyskapunk tonyskapunk self-assigned this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants