More transformer v2 refactoring #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
==========================================
+ Coverage 93.10% 93.60% +0.50%
==========================================
Files 9 9
Lines 551 532 -19
Branches 116 110 -6
==========================================
- Hits 513 498 -15
+ Misses 20 18 -2
+ Partials 18 16 -2
☔ View full report in Codecov by Sentry. |
major
force-pushed
the
transformer-refactor
branch
3 times, most recently
from
82ea91e
to
fbe7fc6
Compare
major
force-pushed
the
transformer-refactor
branch
2 times, most recently
from
f9c0540
to
ea65c35
Compare
|
LGTM but I'll leave the final judgement to @miyunari ;) |
F-X64
approved these changes
Aug 1, 2023
We only use DataEntry from the connection module, so just import it and use it directly to reduce typing. Signed-off-by: Major Hayden <major@redhat.com>
major
force-pushed
the
transformer-refactor
branch
from
ea65c35
to
913dae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the other transformers in line with yesterday's update and also extracts the entry filtering to its own method.