Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push cloud-image-locator container to quay #72

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Conversation

F-X64
Copy link
Member

@F-X64 F-X64 commented Oct 24, 2022

Add secrets and workflow that releases cloud-image-locator container images to quay.
Add GCP cloud image data for completion.

Repo:
https://quay.io/repository/cloudexperience/cloud-image-locator

@F-X64
Copy link
Member Author

F-X64 commented Oct 25, 2022

pre-commit.ci autofix

Copy link
Member

@miyunari miyunari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, up to @major

@miyunari
Copy link
Member

Would it make sense to push the image only, when we create a github release? I found this in the documentation, but I am not 100% sure how it works 😅

@F-X64
Copy link
Member Author

F-X64 commented Oct 25, 2022

Great find @miyunari ;)
The release trigger does make sense for our code release (which currently only involves tagging).
The container release on the other hand should happen much more frequently and independent from our code release cycle (e.g. a cron job trigger running once a week).
Though, for now we should stick to manually releasing the container image for our QE team so we won't spam the registry with unusable images.

@F-X64 F-X64 merged commit 8ace0b3 into main Oct 25, 2022
@F-X64 F-X64 deleted the upload-images-to-quay branch October 25, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants