Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Primary action appears in the action kebab in normal screens #607

Closed
josejulio opened this issue Jul 10, 2020 · 0 comments · Fixed by #613
Closed

[BUG] Primary action appears in the action kebab in normal screens #607

josejulio opened this issue Jul 10, 2020 · 0 comments · Fixed by #613
Labels
bug Something isn't working

Comments

@josejulio
Copy link
Member

Describe the bug
When using the PrimaryToolbar and adding a primary action and several other actions, the primary action appears in the action kebab after the PF4 migration

Expected behavior
The primary action should only appear as the button and not inside the kebab menu (on normal screens)

Screenshots

Screenshot_2020-07-10_13-24-43

Desktop (please complete the following information):

  • OS: Fedora
  • Browser Chrome
  • Version 73.0.3683.103

Additional context

On low size screens, it seems fine, the primary appears in the kebab but not as a button, so i think that there was other change in the HTML.

Screenshot_2020-07-10_13-25-10
@josejulio josejulio added the bug Something isn't working label Jul 10, 2020
josejulio added a commit to josejulio/frontend-components that referenced this issue Jul 14, 2020
@josejulio
Adds back css rule to display/hide first kebab action
409a6fb 
Fixes RedHatInsights#607
@josejulio josejulio mentioned this issue Jul 14, 2020
Merged
josejulio added a commit to josejulio/frontend-components that referenced this issue Jul 14, 2020
@josejulio
Merge branch 'master' into RedHatInsightsgh-607
99b9e61
karelhala added a commit to josejulio/frontend-components that referenced this issue Jul 15, 2020
@karelhala
Merge branch 'master' into RedHatInsightsgh-607
595f6dc
karelhala added a commit to josejulio/frontend-components that referenced this issue Jul 16, 2020
@karelhala
Merge branch 'master' into RedHatInsightsgh-607
8dae9ab
karelhala added a commit to josejulio/frontend-components that referenced this issue Jul 17, 2020
@karelhala
Merge branch 'master' into RedHatInsightsgh-607
857bf36
karelhala added a commit to josejulio/frontend-components that referenced this issue Jul 17, 2020
@karelhala
Merge branch 'master' into RedHatInsightsgh-607
67e86b9
karelhala added a commit that referenced this issue Jul 17, 2020
@josejulio @karelhala
Adds back css rule to display/hide first kebab action (#613)
3440fa9 
Fixes #607

Co-authored-by: Karel Hala <khala@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds back css rule to display/hide first kebab action josejulio/frontend-components
1 participant
@josejulio