Partial Python 3 support

[bbayles]

This PR builds upon the ideas in #22 and introduces partial support for Python 3. I'm not ready to consider Python 3 "well-supported" quite yet, as #25 (keys are coerced to strings) is more visible on Python 3.

Notes:

• I went ahead and used six as the compatibility layer, rather than writing and testing a custom compatibility layer.
• I've defensively added __future__ imports for Python 2 to try to keep behaviors between the major versions as similar as possible (I don't think they're doing much work in practice)
• I've made some style changes as recommended by flake8. I'm not enforcing flake8-correctness in Travis yet, but probably will eventually.
• Keys get coerced to unicode strings instead of byte strings now. This doesn't mean much on Python 2, but it does make it difficult to retrieve bytes objects in Python 3 (previously it was difficult to retrieve str objects on Python 3).

[honzajavorek]

Big +1 to flake8!

On 30 Jul 2016 5:04 p.m., "Bo Bayles" notifications@github.com wrote:

This PR builds upon the ideas in #22
#22 and
introduces partial support for Python 3. I'm not ready to consider Python 3
"well-supported" quite yet, as #22
#22 (keys are
coerced to strings) is more visible on Python 3.

Notes:

• I went ahead and used six as the compatibility layer, rather than
  writing and testing a custom compatibility layer.
• I've defensively added future imports for Python 2 to try to
  keep behaviors between the major versions as similar as possible (I don't
  think they're doing much work in practice)
• I've made some style changes as recommended by flake8
  http://flake8.pycqa.org/en/latest/. I'm enforcing flake8-correctness
  in Travis yet, but probably will eventually.
• Keys get coerced to unicode strings instead of byte strings now.
  This doesn't mean much on Python 2, but it does make it difficult to
  retrieve bytes objects in Python 3 (previously it was difficult to
  retrieve str objects on Python 3).

---

You can view, comment on, or merge this pull request online at:

#44
Commit Summary

• Placate flake8
• Add future imports
• Add six to the mix
• Partial Python 3 support
• Update docs with Known Issues
• Add six to requirements.txt
• Test on Python 3

File Changes

• M .travis.yml
  https://github.com/honzajavorek/redis-collections/pull/44/files#diff-0
  (3)
• M docs/index.rst
  https://github.com/honzajavorek/redis-collections/pull/44/files#diff-1
  (11)
• M redis_collections/init.py
  https://github.com/honzajavorek/redis-collections/pull/44/files#diff-2
  (3)
• M redis_collections/base.py
  https://github.com/honzajavorek/redis-collections/pull/44/files#diff-3
  (26)
• M redis_collections/dicts.py
  https://github.com/honzajavorek/redis-collections/pull/44/files#diff-4
  (36)
• M redis_collections/lists.py
  https://github.com/honzajavorek/redis-collections/pull/44/files#diff-5
  (8)
• M redis_collections/sets.py
  https://github.com/honzajavorek/redis-collections/pull/44/files#diff-6
  (23)
• M requirements.txt
  https://github.com/honzajavorek/redis-collections/pull/44/files#diff-7
  (1)
• A setup.cfg
  https://github.com/honzajavorek/redis-collections/pull/44/files#diff-8
  (3)
• M setup.py
  https://github.com/honzajavorek/redis-collections/pull/44/files#diff-9
  (6)
• M tests/base.py
  https://github.com/honzajavorek/redis-collections/pull/44/files#diff-10
  (3)
• M tests/test_dicts.py
  https://github.com/honzajavorek/redis-collections/pull/44/files#diff-11
  (120)
• M tests/test_lists.py
  https://github.com/honzajavorek/redis-collections/pull/44/files#diff-12
  (11)
• M tests/test_sets.py
  https://github.com/honzajavorek/redis-collections/pull/44/files#diff-13
  (12)

Patch Links:

• https://github.com/honzajavorek/redis-collections/pull/44.patch
• https://github.com/honzajavorek/redis-collections/pull/44.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#44, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AARTMX2Ro71ke0--dWrXPfQF72Qb_8fFks5qa2f3gaJpZM4JY0xL
.

[bbayles]

This is in so more drastic changes to solve #25 (keys are strings) can go forward.

[honzajavorek]

I went ahead and used six as the compatibility layer

👍

I think the most difficult part of the Python 3 support is the unicode/str/bytes confusion indeed. At the time people started to request support for 3 here I didn't even use it yet (I do regularly now), so it was very hard for me to not only spot, but to correctly solve all the corner cases. Thanks for all the great work and thorough approach!

[honzajavorek]

🎉 🎉