Make hiredis uses default CA certs #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
reviewed
Jun 16, 2023
Comment on lines
12
to
18
| def default_ca_file | ||
| OpenSSL::X509::DEFAULT_CERT_FILE | ||
| end | ||
|
|
||
| def default_ca_path | ||
| OpenSSL::X509::DEFAULT_CERT_DIR | ||
| end |
There was a problem hiding this comment.
Suggested change
| def default_ca_file | |
| OpenSSL::X509::DEFAULT_CERT_FILE | |
| end | |
| def default_ca_path | |
| OpenSSL::X509::DEFAULT_CERT_DIR | |
| end |
Let's not expose methods just to access constants.
There was a problem hiding this comment.
I initially added those method to ease testing, but I don't understand anything to minitest, mocking the thing was a bit complex so I dropped the idea.
Would you rather have me use the constant directly, or make those methods private ?
(Edit: my understanding is that you prefer using the constants directly, so I updated the PR in that way)
elthariel
force-pushed
the
lta/fix/hiredis_default_ca
branch
from
f80b08b
to
c5c454d
Compare
|
Thank you! |
|
Thank you for your amazing reactivity @byroot . I wish you a great weekend in the pink city |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using hiredis with
rediss://url without explicitly specifying a CA file/directory fails with a quite obscure message:Resource temporarily unavailableAfter a bit of investigation I realized it was because hiredis wasn't configured with any CA, and wasn't using the default system ones.
Since the ruby implementation worked and uses the default system CA, here's a proposed fix to have a consistent behavior between hiredis and the ruby driver