Rescue OpenSSL::SSL::SSLError for write and write_multi #180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While on version 4 of the
redis
gem, we had a monkey patch to rescueSSL_read: shutdown while in init
errors as suggested here: redis/redis-rb#1174 (comment)This worked fine until we upgrade to
redis
version 5 and our patch wasn't being applied anymore. We recently have been seeing:SSL_write: shutdown while in init
(notice that it'swrite
instead ofread
). I realized that the redis-client code was rescuing SSL errors for theread
: https://github.com/redis-rb/redis-client/blob/master/lib/redis_client/ruby_connection.rb#L102But it wasn't doing it for
write
. This PR adds rescuing ofOpenSSL::SSL::SSLError
towrite
andwrite_multi
.