Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix an error handling bug #341

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

supercaracal
Copy link
Member

@supercaracal supercaracal commented Mar 13, 2024

TestAgainstClusterScale#test_02_scale_in:
RedisClient::CommandError: ERR Please use SETSLOT only with masters. (redis://127.0.0.1:6385)
    vendor/bundle/ruby/3.3.0/gems/redis-client-0.21.0/lib/redis_client/connection_mixin.rb:36:in `call'
    vendor/bundle/ruby/3.3.0/gems/redis-client-0.21.0/lib/redis_client.rb:279:in `block (2 levels) in call'
    vendor/bundle/ruby/3.3.0/gems/redis-client-0.21.0/lib/redis_client/middlewares.rb:16:in `call'
    vendor/bundle/ruby/3.3.0/gems/redis-client-0.21.0/lib/redis_client.rb:278:in `block in call'
    vendor/bundle/ruby/3.3.0/gems/redis-client-0.21.0/lib/redis_client.rb:699:in `ensure_connected'
    vendor/bundle/ruby/3.3.0/gems/redis-client-0.21.0/lib/redis_client.rb:277:in `call'
    test/cluster_controller.rb:147:in `block in finish_resharding'

Although it's a bad way of the error handling.

@supercaracal supercaracal marked this pull request as ready for review March 13, 2024 06:34
@supercaracal supercaracal merged commit 735b529 into redis-rb:master Mar 13, 2024
25 checks passed
@supercaracal supercaracal deleted the fix-test-failure branch March 13, 2024 06:34
@supercaracal supercaracal changed the title test: fix a error handling bug test: fix an error handling bug Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant