Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the error identification middleware optional because of the use case #344

Conversation

supercaracal
Copy link
Member

@supercaracal supercaracal commented Apr 12, 2024

  • Add middleware to ensure Router only handles errors for its clients #310
  • I doubt whether every user needs the error identification middleware or not. I think our 99% users don't use this library in a nested block against multiple clusters. Also, middlewares are called every time by commands and pipelines. It affects the performance in no small measure.
  • The node class doesn't need any dependencies with the middleware. So we should decouple them. The middleware is used by only the router class.

@supercaracal supercaracal changed the title fix: make the error identification optional because of the performance fix: make the error identification middleware optional because of the performance Apr 12, 2024
@supercaracal supercaracal changed the title fix: make the error identification middleware optional because of the performance fix: make the error identification middleware optional because of the use case Apr 12, 2024
@supercaracal supercaracal marked this pull request as ready for review April 13, 2024 05:18
@supercaracal supercaracal merged commit 5d49a47 into redis-rb:master Apr 13, 2024
25 checks passed
@supercaracal supercaracal deleted the make-error-identification-middleware-optional branch April 13, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant