Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent comparison errors #82

Merged

Conversation

supercaracal
Copy link
Member

There might be some cases that some nodes or redis-client reply with unexpected type values.

  1) Error:
RedisClient::TestCluster::PrimaryOnly#test_dedicated_commands:
ArgumentError: comparison of String with 1 failed
    /home/runner/work/redis-cluster-client/redis-cluster-client/lib/redis_client/cluster/router.rb:37:in `sort'
    /home/runner/work/redis-cluster-client/redis-cluster-client/lib/redis_client/cluster/router.rb:37:in `send_command'
    /home/runner/work/redis-cluster-client/redis-cluster-client/lib/redis_client/cluster.rb:21:in `call'
    /home/runner/work/redis-cluster-client/redis-cluster-client/test/redis_client/test_cluster.rb:174:in `block (2 levels) in test_dedicated_commands'
    /home/runner/work/redis-cluster-client/redis-cluster-client/test/redis_client/test_cluster.rb:180:in `block in test_dedicated_commands'
    /home/runner/work/redis-cluster-client/redis-cluster-client/test/redis_client/test_cluster.rb:172:in `each'
    /home/runner/work/redis-cluster-client/redis-cluster-client/test/redis_client/test_cluster.rb:172:in `test_dedicated_commands'

@supercaracal supercaracal marked this pull request as ready for review July 2, 2022 00:23
@supercaracal supercaracal merged commit 14cafa5 into redis-rb:master Jul 2, 2022
@supercaracal supercaracal deleted the fix-prevent-comparison-error branch July 2, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant