Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the call_v style interfaces. #90

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Conversation

casperisfine
Copy link
Contributor

@casperisfine casperisfine commented Aug 16, 2022

Counterpart to redis-rb/redis-client@ef44f08.

That's the interface redis-rb will use, as it avoid splating arguments all the time. It also happens to simplify redis-cluster-client IMO.

@casperisfine casperisfine force-pushed the redis-rb-compat branch 6 times, most recently from 045994f to efc2c69 Compare August 16, 2022 11:03
That's what redis-rb 5.0 uses.
Copy link
Member

@supercaracal supercaracal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement. 👍

@casperisfine
Copy link
Contributor Author

I also pushed a small bugfix: cfb2b7a, various call methods on Pipeline wouldn't execute the passed block.

And 4288704 to help redis-rb decorate the client.

@casperisfine casperisfine merged commit 17669fb into master Aug 16, 2022
@casperisfine casperisfine deleted the redis-rb-compat branch August 16, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants