Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dns resolving is not async #379

Closed
doyoubi opened this issue Sep 16, 2020 · 0 comments · Fixed by #606
Closed

Dns resolving is not async #379

doyoubi opened this issue Sep 16, 2020 · 0 comments · Fixed by #606
Labels
bug

Comments

@doyoubi
Copy link

doyoubi commented Sep 16, 2020 •
edited
Loading

The current get_async_connection internally uses to_socket_addrs to resolve domains which is not async and will block the whole process.
@Marwes Marwes added the bug label Nov 2, 2020
@tasn tasn mentioned this issue May 10, 2022
Closed
Roger added a commit to Roger/redis-rs that referenced this issue May 13, 2022
@Roger
Make dns resolution async, in async runtime
6847aef 
fixes: redis-rs#379
@Roger Roger mentioned this issue May 13, 2022
Merged
Roger added a commit to Roger/redis-rs that referenced this issue May 13, 2022
@Roger
Make dns resolution async, in async runtime
2e030be 
fixes: redis-rs#379
jaymell pushed a commit that referenced this issue May 18, 2022
@Roger
Make dns resolution async, in async runtime (#606)
867de8a 
fixes: #379
gkorland pushed a commit to gkorland/redis-rs that referenced this issue May 24, 2022
@Roger @gkorland
Make dns resolution async, in async runtime (redis-rs#606)
0a33569 
fixes: redis-rs#379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make dns resolution async, in async runtime Roger/redis-rs
2 participants
@Marwes @doyoubi