Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save reconnected connections during retries. #1033

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

nihohit
Copy link
Contributor

@nihohit nihohit commented Jan 18, 2024

This change ensures that reconnect attempts that happen during retries, or new connections that happen after MOVED/ASKING errors, will be saved instead of constantly reconnecting until slots are refreshed.

#1025

@nihohit nihohit marked this pull request as ready for review January 18, 2024 17:57
@nihohit nihohit mentioned this pull request Jan 18, 2024
22 tasks
@nihohit nihohit force-pushed the fix-reconnects branch 2 times, most recently from d57373c to 2ead2df Compare February 23, 2024 11:20
Copy link
Contributor

@jaymell jaymell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

This change ensures that reconnect attempts that happen during retries,
or new connections that happen after MOVED/ASKING errors, will be saved
instead of constantly reconnecting until slots are refreshed.
@nihohit nihohit merged commit 78a37b5 into redis-rs:main Feb 28, 2024
10 checks passed
@nihohit nihohit deleted the fix-reconnects branch February 28, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants