Add higher level utilities for PushManager and Example for Pub/Sub #1193
Conversation
altanozlu
force-pushed
the
add-resp3-examples
branch
2 times, most recently
from
da6673d
to
2806eea
Compare
altanozlu
force-pushed
the
add-resp3-examples
branch
from
2806eea
to
1626d3b
Compare
There was a problem hiding this comment.
Since we have time to play with the API until the first version with this is released, I'd prefer that instead of these slight improvements, we'd make an effort to consider what is the right API to expose to the user.
Do we really need to expose the replace_sender function to the user, or can we just have these functions (or similar ones)? Do we really need the internal replacable sender, or can we make the push manager optional and have it come with a single, irreplacable sender?
Should we expose the internal channel to the user, or just some stream abstraction?
We have an API that works, but until the next release is released, it isn't set in stone. Let's use the time to verify that it's the best API we can have.
| async fn main() -> redis::RedisResult<()> { | ||
| // ?resp3=true enables RESP3 for this connection. | ||
| // Since RESP3 protocol is used there is no need for creating different connections when using PubSub commands. | ||
| let client = redis::Client::open("redis://127.0.0.1/?resp3=true").unwrap(); |
There was a problem hiding this comment.
unrelated to this PR - is there a specification for redis URL? I couldn't find it.
There was a problem hiding this comment.
There was a problem hiding this comment.
I believe we should hide pushmanager from user, and I'd keep replaceable sender for reconnections etc. |
I have added two new functions for MultiplexedConnection and ConnectionManager,
I believe this methods will make easier to use RESP3 with PubSub.