-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for using ahash internally & for redis values #636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Hi folks, |
Optional dependencies implicitly create a feature toggle. |
@djc I think we need a new release for people to be able to use it. |
Well, you can use it now as a Git dependency, and that seems to be orthogonal. |
@djc, It seems that if you use an optional dependency that is not explicitly declared a feature, you're prevented from publishing it on crates.io:
|
Should I raise a PR to create a feature for this then? |
I think this is wrong. If you want to publish qsv to crates.io it's not allowed to have git dependencies but this PR has not yet been released to crates.io. So what you're seeing here just means that the released versions don't have a feature called |
No description provided.