Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2/5] [2] cluster, cluster_client: minor refactorings (change order of code, use Self) #706

Merged
merged 4 commits into from Nov 7, 2022
Merged

[2/5] [2] cluster, cluster_client: minor refactorings (change order of code, use Self) #706

merged 4 commits into from Nov 7, 2022

Conversation

0xWOF
Copy link
Contributor

@0xWOF 0xWOF commented Nov 3, 2022 •
edited

Changes

  • cluster: change orders of declarations
  • cluster_client: add Self::

Effect

  • no public api is changed
  • cluster: implementation is not changed only order of declarations is changed
  • cluster_client: add Self:: it should do not change behavior

Note

@0xWOF 0xWOF mentioned this pull request Nov 3, 2022
Merged
@djc
Copy link
Contributor

djc commented Nov 3, 2022

Please rebase onto main so the first three commits disappear.

@0xWOF 0xWOF force-pushed the cluster_client_refactor_2_2 branch from 5acb2b8 to f387747 Compare November 4, 2022 09:57
@0xWOF
Copy link
Contributor Author

0xWOF commented Nov 4, 2022

I rebase it!

@djc djc merged commit d7d2f2a into redis-rs:main Nov 7, 2022
@0xWOF 0xWOF deleted the cluster_client_refactor_2_2 branch November 8, 2022 12:53
@lucysbot lucysbot mentioned this pull request Jul 4, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0xWOF @djc @utkarshgupta137