Fix empty result from xread_options with deleted entries #712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
xread_options seems to not handle correctly case when a pending message is deleted.
In my understanding, if a pending message is deleted, its id should still be returned https://redis.io/commands/xreadgroup/#what-happens-when-a-pending-message-is-deleted
This is useful for acknowledging them and cleaning the PEL if some messages could not be processed.
Expected vs actual result
The expected result from the test case is:
On redis-rs 0.20.2:
On main an Err is thrown:
This is fixed by converting a nil value from redis when casting as an hash into a empty hash.
I am open to better solutions/suggestions!