fix(test/basic): assert result of con.object_idletime with equal or less than 1 #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess than 1 Result of con.object_idletime is mostly 0. But when machine is slow, it can be 1 or even more. This patch can reduce possibility of test failure because of machine performance not bug of code.
djc
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
con.object_idletimewith equal or less than 1 instead of equal with 0Why
con.object_idletimeis affected by machine. So test is failed intermittently.Potential Risk
con.object_idletimehas bug that return 1 when real value is 0, then this is can't catch the bug.closes #713