Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2/5] [6] cluster: make connect a method & create connection directly #717

Merged
merged 1 commit into from
Nov 11, 2022
Merged

[2/5] [6] cluster: make connect a method & create connection directly #717

merged 1 commit into from
Nov 11, 2022

Conversation

0xWOF
Copy link
Contributor

@0xWOF 0xWOF commented Nov 10, 2022

Changes

  • cluster
    • make connect a method and use parameters from self
    • create connection directly on connect method

Effect

  • cluster:
    • no public api is changed
    • no behavior is changed

Note

@utkarshgupta137 @0xWOF
cluster: make connect a method & create connection directly
5ba897f 
- instead of creating a client first & then get a connection from it, we can create the connection directly
- access username, password, read_from_replicas from self to reduce repetitive parameter passing

cluster: use modified connect method
@0xWOF 0xWOF changed the title cluster: make connect a method & create connection directly [2/5] [6] cluster: make connect a method & create connection directly Nov 10, 2022
@djc djc merged commit 8eda667 into redis-rs:main Nov 11, 2022
@0xWOF 0xWOF deleted the cluster_client_refactor_2_6 branch November 12, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0xWOF @djc @utkarshgupta137