Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine the type of a key #933

Merged
merged 5 commits into from
Aug 28, 2023
Merged

Determine the type of a key #933

merged 5 commits into from
Aug 28, 2023

Conversation

bruaba
Copy link
Contributor

@bruaba bruaba commented Aug 21, 2023

No description provided.

@bruaba
Copy link
Contributor Author

bruaba commented Aug 21, 2023

add get type of a key to redis async connection
follow #931

@jaymell
Copy link
Contributor

jaymell commented Aug 22, 2023

Thanks for the PR!

I personally think I prefer key_type instead of type_key. What do you think? Could we also add a small test -- in test_basic.rs should be fine.

@bruaba
Copy link
Contributor Author

bruaba commented Aug 22, 2023

@jaymell
"I personally think I prefer key_type instead of type_key. What do you think?"
yes you are right it sounds better in English, I was thinking in French hence the type key.

"Could we also add a small test -- in test_basic.rs should be fine."
I added some tests in the test_basic.rs file, hope they will be fine for you.

@jaymell
Copy link
Contributor

jaymell commented Aug 28, 2023

@nihohit LGTM

@nihohit nihohit merged commit 163f5c2 into redis-rs:main Aug 28, 2023
10 checks passed
@jaymell jaymell mentioned this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants