Multi-platform docker build fix #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found the source of thie issue, in docker buildx A bug in setup-buildx-action helped highlight the fix, a downgrade to buildx. |
|
In CI: ensuring just these tests pass: https://github.com/redis-stack/redis-stack/actions/runs/3998114095 Validation of the separate edge build run (not using buildx): https://github.com/redis-stack/redis-stack/actions/runs/3995339550. Note - as part of this we re-disabled the arm docker checks. Those were enabled in a bad merge, hence putting these two together. |
ofekshenawa
approved these changes
Jan 25, 2023
This was referenced Jan 25, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker builds fail, due to docker notiing that an image is a manifest. The docker API notes, when pulling edge dockers that edge-x86_64 is a manifest - though it's clearly an image. When running an inspect on an image, or pulling via tag, or sha - docker reports that
Error: No such image: redisfab/redis-stack-server:edge-x86_64, yet in other cases, indicates that this is a manifest.