Fixing arm on-target compilation #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofekshenawa
approved these changes
Feb 15, 2023
|
@ofekshenawa This change solves the jammy issue. When it gets cherry picked into 7.0 the same versions can match. But, in 6.2, I'll need to up the packagedredisversion given the compile flag for jammy. This is the reason that the redis package itself, is cached, and versioned independently of the stack - in the dependencies folder in S3. Cloud images should work immediately with this. |
ofekshenawa
approved these changes
Feb 16, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the issue where the ARM build, for redis was tied to ubuntu18.04. It led to a bug where some Ubuntu ARM instances, due to the verison of libssl, redis-stack woudl fail to start. As a side benefit this should also make it easy to support more platforms in the future.