-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JSON.MSET Command #131
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #131 +/- ##
==========================================
- Coverage 93.25% 92.73% -0.53%
==========================================
Files 77 78 +1
Lines 4582 4611 +29
Branches 424 427 +3
==========================================
+ Hits 4273 4276 +3
- Misses 187 212 +25
- Partials 122 123 +1
☔ View full report in Codecov by Sentry. |
@@ -725,6 +725,63 @@ public async Task GetAsync() | |||
Assert.Equal(35, people[1]!.Age); | |||
} | |||
|
|||
[Fact] | |||
[Trait("Category","edge")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. We'll remove this once it hits a versioned docker. Similar to the skipif in other tests for other clients.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be in docker & the main ubuntu package - the windows image downloads the tarball directly and installs it in WSL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a skip attribute that lets you skip a test you don't want to run, but it doesn't permit conditionals unfortunately, there are ways to setup some conditionals to override the behavior (several OSS projects do something of the like) but that's kind of overkill for something that needs a relatively simple filter like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Closes #128