Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: new hash pages #217

Merged
merged 10 commits into from
Jun 6, 2024
Merged

DEV: new hash pages #217

merged 10 commits into from
Jun 6, 2024

Conversation

dwdougherty
Copy link
Collaborator

@dwdougherty dwdougherty commented May 14, 2024 •
edited by jira bot

Ticket: DOC-3602

Reviewers:

  • Staged preview links are below.
  • Ignore the SVG files. They were automatically generated by the old build script and every command has one. They do not display on the docs site and they'll be removed soon.

@dwdougherty dwdougherty self-assigned this May 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Staging links:
https://redis.io/docs/staging/DOC-3602/commands/hexpire/
https://redis.io/docs/staging/DOC-3602/commands/hexpireat/
https://redis.io/docs/staging/DOC-3602/commands/hexpiretime/
https://redis.io/docs/staging/DOC-3602/commands/hpersist/
https://redis.io/docs/staging/DOC-3602/commands/hpexpire/
https://redis.io/docs/staging/DOC-3602/commands/hpexpireat/
https://redis.io/docs/staging/DOC-3602/commands/hpexpiretime/
https://redis.io/docs/staging/DOC-3602/commands/hpttl/
https://redis.io/docs/staging/DOC-3602/commands/httl/
https://redis.io/docs/staging/DOC-3602/develop/data-types/hashes

@dwdougherty dwdougherty added CE 7.4 and removed dev labels May 20, 2024
andy-stark-redis
andy-stark-redis requested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The passive voice things are just minor suggestions that you should feel free to ignore, but it looks like there are one or two actual glitches to look at too.

content/commands/hexpire/index.md Outdated Show resolved Hide resolved
content/commands/hexpire/index.md Outdated Show resolved Hide resolved
content/commands/hexpire/index.md Outdated Show resolved Hide resolved
content/commands/hexpire/index.md Outdated Show resolved Hide resolved
content/commands/hgetf/index.md Outdated Show resolved Hide resolved
content/commands/hsetf/index.md Outdated Show resolved Hide resolved
content/commands/httl/index.md Outdated Show resolved Hide resolved
content/commands/httl/index.md Outdated Show resolved Hide resolved
content/commands/hpttl/index.md Outdated Show resolved Hide resolved
content/develop/data-types/hashes.md Outdated Show resolved Hide resolved
andy-stark-redis
andy-stark-redis approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwdougherty dwdougherty merged commit 2f513f2 into main Jun 6, 2024
4 checks passed
@dwdougherty dwdougherty deleted the DOC-3602 branch June 6, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiorKogan LiorKogan LiorKogan left review comments

@andy-stark-redis andy-stark-redis andy-stark-redis approved these changes

@mich-elle-luna mich-elle-luna Awaiting requested review from mich-elle-luna

Assignees

@dwdougherty dwdougherty

Labels
CE 7.4 do not merge yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dwdougherty @LiorKogan @andy-stark-redis