BUG: BFReserveArgs - error_rate & capacity (#2763)

the error_rate and capacity parameters should not be optional - corrected
redis · Oct 30, 2023 · 84f46c3 · 84f46c3
1 parent 343016b
commit 84f46c3
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/probabilistic.go b/probabilistic.go
@@ -150,12 +150,7 @@ func (c cmdable) BFReserveNonScaling(ctx context.Context, key string, errorRate
 func (c cmdable) BFReserveWithArgs(ctx context.Context, key string, options *BFReserveOptions) *StatusCmd {
 	args := []interface{}{"BF.RESERVE", key}
 	if options != nil {
-		if options.Error != 0 {
-			args = append(args, options.Error)
-		}
-		if options.Capacity != 0 {
-			args = append(args, options.Capacity)
-		}
+		args = append(args, options.Error, options.Capacity)
 		if options.Expansion != 0 {
 			args = append(args, "EXPANSION", options.Expansion)
 		}