Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clients should identify themselves on connect #2654

Closed
chayim opened this issue Jul 19, 2023 · 3 comments · Fixed by #2659
Closed

Clients should identify themselves on connect #2654

chayim opened this issue Jul 19, 2023 · 3 comments · Fixed by #2659
Labels

Comments

@chayim
Copy link
Contributor

chayim commented Jul 19, 2023

CLIENT SETINFO is a new fire-and-forget command that is available as part of redis 7.2. Clients should send the lowercased version of the client name (i.e redis-py, jedis, go-redis) as part of the initial connect, after authenticating to the server.

@chayim chayim added the feature label Jul 19, 2023
@SoulPancake
Copy link
Contributor

Would like to work on this @chayim

@rueian
Copy link
Contributor

rueian commented Jul 25, 2023

Hi @chayim,

Should clients always send their own name to the server or should clients let users decide what value to send?

@chayim
Copy link
Contributor Author

chayim commented Jul 26, 2023

@rueian Clients should send their own name and their current version - notice the arguments. There will, of course be versions of redis (prior to 7.2) that don't support this. So, the general idea is to send always, and fail silently when not supported by the redis server.

I'm a fan of fire and forget, versus check version then fire.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants