Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for CLIENT SETINFO #2659

Merged
merged 13 commits into from
Sep 14, 2023

Conversation

SoulPancake
Copy link
Contributor

@SoulPancake SoulPancake marked this pull request as draft July 23, 2023 05:55
@chayim chayim requested a review from ofekshenawa July 23, 2023 08:50
@chayim
Copy link
Contributor

chayim commented Jul 23, 2023

@ofekshenawa thought you should take a look given what we'd discussed.

@SoulPancake SoulPancake marked this pull request as ready for review July 23, 2023 17:49
@ofekshenawa
Copy link
Collaborator

@SoulPancake LGTM!
Thank you for your contribution.

@monkey92t
Copy link
Collaborator

@SoulPancake

redis.doc: The CLIENT SETINFO command assigns various info attributes to the current connection which are displayed in the output of [CLIENT LIST](https://redis.io/commands/client-list) and [CLIENT INFO](https://redis.io/commands/client-info).

As described in the Redis documentation, it represents the state of a network connection rather than just a simple command.

@monkey92t
Copy link
Collaborator

monkey92t commented Aug 13, 2023

We should invoke this method during connection initialization and ignore failures (for versions < 7.2) link: #2654 (comment)

@ofekshenawa ofekshenawa merged commit 3b0d10b into redis:master Sep 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clients should identify themselves on connect
4 participants