-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting and scaning interface{} values. #118
Conversation
@dim ping :) I am not worried about the code, but more about approach in general. |
return "0", nil | ||
} | ||
default: | ||
b, err := Marshal(vv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably define a type Encodable interface { EncodeRedis() (string, error) }
and return an error on default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see #121 too
5688a18
to
7fc2e91
Compare
@dim PTAL Before
After
|
@dim ping |
Hey, sorry, I'm away until next week, but results look good |
Np, this can wait. |
@dim last time ping :) |
Sorry, traveling (again), will review this week, promise, but should be OK
to merge in the meantime anyway
|
7d494c4
to
3c1f2bd
Compare
Allow setting and scaning interface{} values.
Should make client a little bit more convenient to use. @dim?
Fixes #121. Before
After