Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1786
Added a new
PoolHook
interface allowing the user to add two new hooks that would be called before and after the creation of a connection, allowing the user - among other stuff - to measure the connection latency.User still uses the
AddHook
interface but providing an extended interface which supports the two methods required by the pool.An example can be found here https://github.com/go-redis/redis/pull/1803/files#diff-ee4b7901a404913de455c4b45c583a3d0bf51e6c3abc06c93c2a1fa6c3eac235R16
What is missing
Does not support the
clone
behaviour used by functions likeClient.WithTimeout
which for the client hooks it creates a list by using a shallow copy, decoupling hooks from the former and the new cloned client.Current proposal does not support this, since the pool is shared by all of the cloned clients.