Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NewXPendingResult for unit testing XPending #2066

Merged
merged 1 commit into from Apr 5, 2022
Merged

Add NewXPendingResult for unit testing XPending #2066

merged 1 commit into from Apr 5, 2022

Conversation

evilstreak
Copy link
Contributor

I came across this gap whilst writing a unit test. Hopefully this is the right way to add it!

@evilstreak
Copy link
Contributor Author

Looking at the two failing checks:

  • The commit message linter wants a type. I've looked through previous commits to work out the right thing to use, but I get the sense this may only have been introduced recently, as they're mostly typeless. Would this be feat, as it's changing the code to add something new?
  • The golang linter is unhappy about the already-existing use of netErr.Temporary in error.go: https://github.com/go-redis/redis/blob/master/error.go#L94. Given that's already existing, I don't think it causes a problem with this commit.

@vmihailenco
Copy link
Collaborator

Would this be feat, as it's changing the code to add something new?

Yes, feat looks the right choice here. I will use squah button.

I don't think it causes a problem with this commit

👍

@vmihailenco vmihailenco merged commit b7fd09e into redis:master Apr 5, 2022
@evilstreak
Copy link
Contributor Author

Thanks!

@evilstreak evilstreak deleted the add-new-x-pending-result branch April 5, 2022 11:03
evilaffliction pushed a commit to reactive-go/redis that referenced this pull request Jun 15, 2022
evilaffliction pushed a commit to reactive-go/redis that referenced this pull request Jun 15, 2022
evilaffliction pushed a commit to reactive-go/redis that referenced this pull request Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants